Backport Django 4.1 compatibility fixes to v2#1413
Merged
Conversation
Removed in django 4.1.
sjdemartini
approved these changes
May 25, 2023
sjdemartini
left a comment
sjdemartini
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure the status of graphene-django v2, but the changes here LGTM
firaskafri
approved these changes
May 25, 2023
ulgens
approved these changes
May 25, 2023
Author
|
Any thoughts on why the build could be failing? Doesn't seem to be related to my changes, I think? |
kiendang
approved these changes
May 26, 2023
Contributor
|
@santiagoaguiar just needed to backport a bunch of test and CI updates as well. all settled now. |
Collaborator
|
@santiagoaguiar Just released v2.16.0 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports e584d5e to v2 to be used with Django 4.1.
Hoping we can get this to a 2.16 release 🙏 .